Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): modify display for disabled protocol setup steps in ODD #13502

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Sep 8, 2023

closes RQA-1512

Overview

We want to remove the arrow for disabled ProtocolSetupStep buttons.

Test Plan

  • Ensure disabled ProtocolSetupSteps do not render an arrow, and that the details align right.
Screen Shot 2023-09-08 at 2 46 35 PM

Changelog

  • conditionally render arrow Icon based on whether button is disabled or not

Risk assessment

low

@ncdiehl11 ncdiehl11 requested review from a team as code owners September 8, 2023 18:47
@ncdiehl11 ncdiehl11 requested review from smb2268 and removed request for a team September 8, 2023 18:47
@ncdiehl11 ncdiehl11 self-assigned this Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #13502 (bf0ea7a) into chore_release-7.0.0 (dfa0892) will decrease coverage by 0.05%.
Report is 1 commits behind head on chore_release-7.0.0.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13502      +/-   ##
=======================================================
- Coverage                71.33%   71.29%   -0.05%     
=======================================================
  Files                     2418     2418              
  Lines                    67908    67981      +73     
  Branches                  7876     7913      +37     
=======================================================
+ Hits                     48443    48467      +24     
- Misses                   17623    17656      +33     
- Partials                  1842     1858      +16     
Flag Coverage Δ
app 68.86% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../src/pages/OnDeviceDisplay/ProtocolSetup/index.tsx 76.11% <50.00%> (-0.58%) ⬇️

... and 24 files with indirect coverage changes

@ncdiehl11 ncdiehl11 changed the base branch from edge to chore_release-7.0.0 September 8, 2023 18:47
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖌️

app/src/pages/OnDeviceDisplay/ProtocolSetup/index.tsx Outdated Show resolved Hide resolved
Co-authored-by: Jethary Rader <[email protected]>
@ncdiehl11 ncdiehl11 merged commit 124f184 into chore_release-7.0.0 Sep 11, 2023
@ncdiehl11 ncdiehl11 deleted the app_fix-disabled-protocolsetup-buttons branch September 11, 2023 16:39
jerader pushed a commit that referenced this pull request Sep 12, 2023
…3502)

* fix(app): remove arrow from disabled protocol setup steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants