Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api,shared-data): Reference stable deck slot IDs instead of unstable enum names #13499

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Sep 8, 2023

Overview

Labware definitions can adjust their gripper offsets depending on which slot they're in.

Currently, they specify this with names like SLOT_D3. But those names are internal and unstable. This PR switches them to be like D3, which is more stable, and exactly matches the keys in the deck definition.

Test Plan

  • Confirm the offsets still apply.

Review requests

None in particular.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner September 8, 2023 15:23
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #13499 (3510aaa) into chore_release-7.0.0 (017593d) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.0.0   #13499   +/-   ##
====================================================
  Coverage                71.33%   71.33%           
====================================================
  Files                     2419     2418    -1     
  Lines                    67910    67908    -2     
  Branches                  7876     7876           
====================================================
  Hits                     48443    48443           
+ Misses                   17625    17623    -2     
  Partials                  1842     1842           
Flag Coverage Δ
app 68.87% <ø> (+<0.01%) ⬆️
g-code-testing 96.44% <ø> (ø)
labware-library 49.17% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 46.09% <ø> (ø)
shared-data 73.88% <ø> (ø)
step-generation 87.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
api/src/opentrons/protocol_engine/state/labware.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Opentrons).

@SyntaxColoring SyntaxColoring changed the title fix(api,shared-data): Remove instead of slot source code name. fix(api,shared-data): Reference stable deck slot IDs instead of unstable enum names Sep 8, 2023
Copy link
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you caught this! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants