Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): generify update robot message #13236

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

shlokamin
Copy link
Member

Overview

When updating a flex via the desktop app we still show "OT-2" as the robot name. This PR uses "robot" instead to make it generic.

Risk assessment

Low

@shlokamin shlokamin requested a review from sfoster1 August 4, 2023 17:50
@shlokamin shlokamin requested a review from a team as a code owner August 4, 2023 17:50
@shlokamin shlokamin requested review from b-cooper and removed request for a team August 4, 2023 17:50
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #13236 (eb3a901) into internal-release_0.14.0 (a43a58a) will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           internal-release_0.14.0   #13236      +/-   ##
===========================================================
- Coverage                    72.52%   72.12%   -0.41%     
===========================================================
  Files                         2392     1571     -821     
  Lines                        66072    51955   -14117     
  Branches                      7338     3281    -4057     
===========================================================
- Hits                         47921    37470   -10451     
+ Misses                       16404    13969    -2435     
+ Partials                      1747      516    -1231     
Flag Coverage Δ
app 43.84% <ø> (-27.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 822 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@shlokamin shlokamin merged commit 0ad7167 into internal-release_0.14.0 Aug 4, 2023
@shlokamin shlokamin deleted the app_generify-update-text branch August 4, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants