fix(app): show robot network connection in app if able to communicate via that connection #13206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via that connection adds a check to ensure a connected network status ip reported by a robot has a healthy response from the app discovery-client. for example, robots connected to a different wifi network than the client app should not show a wifi connection in the app, because the app cannot communicate with that robot via wifi. closes RQA-1150
Codecov Report
@@ Coverage Diff @@
## internal-release_0.14.0 #13206 +/- ##
===========================================================
+ Coverage 72.51% 72.59% +0.08%
===========================================================
Files 2392 2365 -27
Lines 66004 65244 -760
Branches 7327 7194 -133
===========================================================
- Hits 47865 47367 -498
+ Misses 16392 16140 -252
+ Partials 1747 1737 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
adds a check to ensure a connected network status ip reported by a robot has a healthy response from the desktop app discovery-client. for example, robots connected to a different wifi network than the client app should not show a wifi connection in the app, because the app cannot communicate with that robot via wifi. updated robot settings networking tab, and robot status header rendered on devices and device details pages.
closes RQA-1150
example robot settings networking tab when robot connected to a different wifi network:
Test Plan
Changelog
Review requests
confirm on robot connected to different wifi network than app
Risk assessment
low