fix(app): poll instrument info for desktop protocol setup #13192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## internal-release_0.14.0 #13192 +/- ##
===========================================================
- Coverage 72.53% 72.26% -0.27%
===========================================================
Files 2369 2371 +2
Lines 65511 66387 +876
Branches 7215 7514 +299
===========================================================
+ Hits 47518 47976 +458
- Misses 16255 16619 +364
- Partials 1738 1792 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shlokamin
approved these changes
Aug 4, 2023
To avoid scenarios where users complete a wizard flow launched from the protocol setup steps only to return to a list item that still shows the old value, employ a background poll of the instruments endpoint in addition to the on complete refetches. this way updates are visible regardless of whether ODD or Desktop was used to complete the wizard. Closes RQA-1139
b-cooper
force-pushed
the
app_fix-calibration-cache-busting
branch
from
ad4d47e to
3ecbbd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
To avoid scenarios where users complete a wizard flow launched from the protocol setup steps only to return to a list item that still shows the old value, employ a background poll of the instruments endpoint in addition to the on complete refetches. this way updates are visible regardless of whether ODD or Desktop was used to complete the wizard.
Closes RQA-1139
Review requests
Risk assessment
low