Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): make update flow copy robot agnostic #13131

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

b-cooper
Copy link
Contributor

Overview

Instead of instructing users to update their OT-2, instruct them to update their robot.

Risk assessment

low

@b-cooper b-cooper requested a review from a team as a code owner July 19, 2023 15:25
Instead of instructing users to update their OT-2, instruct them to update their robot.
@b-cooper b-cooper force-pushed the app_update-modal-copy-generic branch from b6ca061 to a45da7e Compare July 19, 2023 15:26
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #13131 (36ddba7) into edge (15fcb0e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13131      +/-   ##
==========================================
+ Coverage   72.47%   72.50%   +0.02%     
==========================================
  Files        2353     2361       +8     
  Lines       64902    65249     +347     
  Branches     7188     7337     +149     
==========================================
+ Hits        47040    47306     +266     
- Misses      16123    16158      +35     
- Partials     1739     1785      +46     
Flag Coverage Δ
app 71.33% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/organisms/UpdateAppModal/index.tsx 100.00% <ø> (ø)

... and 26 files with indirect coverage changes

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! fixed the linting error

@smb2268 smb2268 merged commit 1cff090 into edge Jul 24, 2023
@smb2268 smb2268 deleted the app_update-modal-copy-generic branch July 24, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants