Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add ListItem component #13128

Merged
merged 5 commits into from
Jul 19, 2023
Merged

feat(app): add ListItem component #13128

merged 5 commits into from
Jul 19, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 18, 2023

Overview

add ListItem component

design
https://www.figma.com/file/OIdG64Q5cgvEw82ish5Eee/Design-System-(Flex)?node-id=1224%3A64042&mode=dev

ListItem has a couple of pseudo classes in Figma, but Mel decided to remove them. Now ListItem is close to Banner component but much simpler since ListItem is a container that has a couple of styles such as background-color, height, width, padding.

related thread

use ListItem for EstopPressedModal for touchscreen app
Screenshot 2023-07-18 at 5 22 46 PM

close RAUT-569

Test Plan

run storybook

Changelog

  • add ListItem component, test and stories
  • update EstopPressedModal to use ListItem

Review requests

Risk assessment

low

add ListItem component
@koji koji requested a review from a team July 18, 2023 21:14
@koji koji marked this pull request as ready for review July 18, 2023 21:14
@koji koji requested a review from a team as a code owner July 18, 2023 21:14
@koji koji requested review from jerader and removed request for a team July 18, 2023 21:14
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #13128 (27a63da) into edge (623561c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13128   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files        2388     2389    +1     
  Lines       65882    65886    +4     
  Branches     7305     7305           
=======================================
+ Hits        47791    47797    +6     
+ Misses      16344    16343    -1     
+ Partials     1747     1746    -1     
Flag Coverage Δ
app 71.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/atoms/ListItem/index.tsx 100.00% <100.00%> (ø)
app/src/organisms/EstopModal/EstopPressedModal.tsx 89.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

@koji koji removed the request for review from jerader July 18, 2023 21:27
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🦅

app/src/atoms/ListItem/ListItem.stories.tsx Outdated Show resolved Hide resolved
@koji koji merged commit d8e9d55 into edge Jul 19, 2023
@koji koji deleted the feat_add-listitem-component branch July 19, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants