Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): redirect to run summary screen based on run endpoint #13125

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

shlokamin
Copy link
Member

Overview

This PR changes the app's current run route logic to reroute based on info coming from the /runs/runId endpoint rather than the /runs endpoint. This is because the run summary screen reads data from the /runs/runId endpoint and we want run state information to be coming from the same place.

This fixes a bug where a run would succeed/fail but we wouldn't render the run succeeded/failed spash screen inside the run summary screen. The reason this bug was happening was because the app would redirect the run summary screen when the /runs endpoint reflected that the current run is in a completed/failed/stop requested state. BUT the run summary screen only renders the splash when the /runs/runId endpoint reflects that the run is in a completed/failed state. Because these are two different endpoints with two different react queries with two different refetch intervals, the data got out of sync.

closes RQA-1098

Risk assessment

Low

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #13125 (370cc47) into edge (03c61e8) will decrease coverage by 0.62%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13125      +/-   ##
==========================================
- Coverage   73.15%   72.53%   -0.62%     
==========================================
  Files        2337     2388      +51     
  Lines       64484    65873    +1389     
  Branches     7111     7305     +194     
==========================================
+ Hits        47172    47782     +610     
- Misses      15587    16345     +758     
- Partials     1725     1746      +21     
Flag Coverage Δ
app 71.20% <0.00%> (-2.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/App/hooks.ts 12.00% <0.00%> (-0.77%) ⬇️

... and 51 files with indirect coverage changes

@shlokamin shlokamin marked this pull request as ready for review July 18, 2023 19:15
@shlokamin shlokamin requested a review from a team as a code owner July 18, 2023 19:15
@shlokamin shlokamin requested review from b-cooper and koji and removed request for a team July 18, 2023 19:15
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@shlokamin shlokamin merged commit 57b7c9b into edge Jul 24, 2023
@shlokamin shlokamin deleted the app_odd-fix-unconsistent-run-completed-spash branch July 24, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants