fix(app): fix run failed modal styling #13103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add padding to error message container and change the max height. also add style to scrollbar fix RQA-1064 partially
Codecov Report
@@ Coverage Diff @@
## edge #13103 +/- ##
=======================================
Coverage 72.46% 72.46%
=======================================
Files 2388 2388
Lines 66021 66022 +1
Branches 7319 7319
=======================================
+ Hits 47840 47841 +1
Misses 16442 16442
Partials 1739 1739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
approved these changes
Jul 17, 2023
| overflow-y: ${OVERFLOW_AUTO}; | ||
| &::-webkit-scrollbar { | ||
| width: 0.75rem; |
There was a problem hiding this comment.
Suggested change
| width: 0.75rem; | |
| width: SPACING.spacing12; |
There was a problem hiding this comment.
I think we decided to use hard coded value for width, height, and size since SPACING for padding, margin, gap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add padding to error message container and change the max height. also add style to scrollbar
Error message will be implemented when the endpoint is available.
fix RQA-1064
Test Plan
Changelog
Review requests
Risk assessment