feat(app): add e-stop modals for odd #13093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add two modals for e-stop. One is EstoPressedModal and the other is EstopMissingModal.
Codecov Report
@@ Coverage Diff @@
## edge #13093 +/- ##
==========================================
- Coverage 73.14% 72.51% -0.64%
==========================================
Files 2337 2390 +53
Lines 64487 65916 +1429
Branches 7111 7318 +207
==========================================
+ Hits 47172 47797 +625
- Misses 15590 16373 +783
- Partials 1725 1746 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
jerader
approved these changes
Jul 17, 2023
| }) | ||
|
|
||
| it('should render text and button - inactive run', () => { | ||
| props.isActiveRun = false |
There was a problem hiding this comment.
wow, i didn't realize you can reinitialize props this way, that's cool!
shlokamin
reviewed
Jul 17, 2023
no stroke for e-stop modals for e-stop missing modal of the touchscreen app, the size was changed into medium from large
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add two modals for e-stop. One is EstopPressedModal and the other is EstopMissingModal.
Combine DesktopEstopPressedModal and EstopPressedModal into one component as well as DesktopMissingModal.
Also add
errortype to Chip component.The function will be added by following PRs.
design
https://www.figma.com/file/t4GKKfUA3RRfgHFxPbVVjV/Release%3A-Touchscreen-August-update?type=design&node-id=629-52540&mode=design&t=ucnIizoesp9Fg9hI-0
Test Plan
check EstopPressedModal and EstopMissingModal under
DesktopandODDChangelog
errortype to Chip component and testReview requests
Risk assessment
low