fix(app): send custom labware files to flex with protocol #13089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as the create run from protocol function spreads in all known custom labware files when creating a protocol record on a robot, the send to robot feature should also include custom labware.
b-cooper
requested review from
brenthagen,
skowalski08 and
shlokamin
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## edge #13089 +/- ##
==========================================
+ Coverage 72.55% 72.59% +0.03%
==========================================
Files 2380 2380
Lines 65857 66043 +186
Branches 7274 7325 +51
==========================================
+ Hits 47784 47941 +157
- Misses 16337 16351 +14
- Partials 1736 1751 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
skowalski08
approved these changes
Jul 12, 2023
b-cooper
deleted the
app_fix-send-custom-labware-over-with-protcol-to-flex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just as the create run from protocol function spreads in all known custom labware files when creating a protocol record on a robot, the send to robot feature should also include custom labware.
props to @skowalski08 for uncovering this bug
Review requests
Risk assessment
low