-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api, app, shared-data, pd): use new flex pipette names in backend & clients #13082
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #13082 +/- ##
==========================================
- Coverage 72.20% 72.13% -0.08%
==========================================
Files 1559 1543 -16
Lines 51750 51379 -371
Branches 3229 3146 -83
==========================================
- Hits 37366 37061 -305
+ Misses 13875 13812 -63
+ Partials 509 506 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense to me. Thanks for your quick response on this.
This approach would cause existing analyses & run logs on the robot to raise errors. It would require users to reset their database. Is it okay to have to do that?
👍 Yeah, this is the same sort of thing as with #12571. If we have to have a breaking API change like this, we may as well rip off the band-aid while it's still internal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when running analysis on a protocol that uses a pipette load name of p1000_single_flex
i get the following analysis error:
ProtocolEngineError [line 28]: Error 4000 GENERAL_ERROR (ProtocolEngineError): UnexpectedProtocolError: 'p1000_single_flex_v1'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you already have this PR open, can you go ahead and do the requirements listed in this ticket?
Make sure the "gen3" version of the pipettes get passed into the hardware controller.
@@ -21,16 +21,16 @@ | |||
"p20_multi_gen2", | |||
"p50_single", | |||
"p50_multi", | |||
"p50_single_gen3", | |||
"p50_multi_gen3", | |||
"p50_single_flex", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the gen3
in these dev types for now and also test on a robot w/ app to see if we need to additionally add the _flex
models to schema v1 for pipettes (hopefully we do not).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now, but see comment I added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested pipette attach, calibration, LPC & running python protocol with flex_8channel_1000
& p50_single_gen3
pipettes without any issues!
Overview
#12966 updated the Flex's pipette names from
.._gen3
to.._flex
which created a conflict with pipette names expected by the engine & PAPI. This PR updates the engine to switch to using the new names, while adding a temporary backwards compatible shim to python API to convert the old names to new ones.Ticket to remove the backwards compatibility shim before launch: RSS-284
Update after PR reviews:
gen3
references in v1 pipette definitions toflex
Test Plan
Review requests
This approach would cause existing analyses & run logs on the robot to raise errors. It would require users to reset their database. Is it okay to have to do that?
Risk assessment
This is basically a fix for the breaking change introduced in the above linked PR so that way it reduces risk, but it also fixes it by switching the engine over to use the new names so we should be careful with merging it in.