Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Switch plunger backlash to pre-load for aspirations #13076

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

andySigler
Copy link
Contributor

Overview

This PR changes backlash to ensure that all aspirations are pre-loaded.

Test data is showing that aspiration volumes are varying more between pipettes with the currently implemented backlash compensation. This is likely due to the variations between each pipette's true backlash distance causing both differences in aspiration distances. This is especially true at low volumes, where we are seeing large variations in volumes between pipettes.

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested a review from a team as a code owner July 11, 2023 02:45
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, talked through it in person and aspirate-preload makes sense and the implementation looks right. Nice!

@andySigler andySigler merged commit 11b4775 into edge Jul 11, 2023
@andySigler andySigler deleted the fix-api-plunger-backlash-switch-to-pre-load-aspirate branch July 11, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants