fix(hardware): specify nodes when clearing move groups #13072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andySigler
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Specify expected nodes when clearing move groups
andySigler
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Specify expected nodes when clearing move groups
andySigler
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Specify expected nodes when clearing move groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The call to
ensure_sendwhen clearing move groups didn't specify what nodes to listen for and it ended up printing out a ton of errors. This should eliminate those errors.Test Plan
Run ot3repl on an OT-3 with this change, make sure the warning messages don't pop up.
Changelog
Review requests
Risk assessment