Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, labware library): prevent white screen when opening adapter definitions #13063

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Jul 10, 2023

Overview

This PR fixes a bug in both LL + the opentrons app where clicking on an adapter would cause a white screen. It also moves the measurement guide assets into the components library since they are identical between LL and the app.

Not sure what to do about the images for an adapter's spacing (probably need new assets) but for now I think this is fine.

Review requests

Go to an adapter's detail page on both the app and LL, there should no longer be a white screen.

Risk assessment

Low

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #13063 (e317052) into edge (4becec5) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13063      +/-   ##
==========================================
+ Coverage   72.28%   72.54%   +0.26%     
==========================================
  Files        2372     2355      -17     
  Lines       65042    65186     +144     
  Branches     7286     7325      +39     
==========================================
+ Hits        47015    47291     +276     
+ Misses      16324    16138     -186     
- Partials     1703     1757      +54     
Flag Coverage Δ
app 71.37% <ø> (+0.10%) ⬆️
components 63.99% <ø> (-0.43%) ⬇️
labware-library 49.27% <ø> (-0.35%) ⬇️
protocol-designer 45.27% <ø> (+1.20%) ⬆️
shared-data 79.62% <ø> (+3.23%) ⬆️
step-generation 87.17% <ø> (+2.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/organisms/LabwareDetails/Dimensions.tsx 100.00% <ø> (ø)
app/src/organisms/LabwareDetails/InsertDetails.tsx 0.00% <ø> (ø)
...pp/src/organisms/LabwareDetails/WellDimensions.tsx 80.95% <ø> (ø)
app/src/organisms/LabwareDetails/WellSpacing.tsx 91.66% <ø> (ø)
app/src/organisms/LabwareDetails/index.tsx 81.08% <ø> (ø)
...ents/src/images/labware/measurement-guide/index.ts 31.81% <ø> (ø)
...brary/src/components/LabwareDetails/Dimensions.tsx 12.50% <ø> (ø)
...ry/src/components/LabwareDetails/InsertDetails.tsx 0.00% <ø> (ø)
...rc/components/LabwareDetails/LabwareDetailsBox.tsx 0.00% <ø> (ø)
...y/src/components/LabwareDetails/WellDimensions.tsx 5.55% <ø> (ø)
... and 3 more

... and 67 files with indirect coverage changes

@shlokamin shlokamin marked this pull request as ready for review July 10, 2023 21:59
@shlokamin shlokamin requested a review from a team as a code owner July 10, 2023 21:59
@shlokamin shlokamin requested review from smb2268 and removed request for a team July 10, 2023 21:59
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! unrelated but we probably should add an adapter option to the category filter options.

Screen Shot 2023-07-11 at 9 10 56 AM

@shlokamin shlokamin merged commit 6584665 into edge Jul 24, 2023
@shlokamin shlokamin deleted the move_util-to-shared-data branch July 24, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants