Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix InterventionModal's error on Storybook #13061

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 8, 2023

Passing mock rundata to avoid causing the undefined data rloload rror

Overview

Passing mock run data to avoid causing the undefined data load error

[current]
Screenshot 2023-07-08 at 6 10 33 PM

[passing mockRunData]
Screenshot 2023-07-08 at 6 09 13 PM

Test Plan

  • run Storybook
  • App -> Organisms -> InterventionModal

Changelog

  • passing mockRunData to Storybook

Review requests

Risk assessment

low

Passing mock rundata to avoid causing the undefined data rloload rror
@koji koji requested a review from a team July 8, 2023 22:11
@koji koji marked this pull request as ready for review July 8, 2023 22:11
@koji koji requested a review from a team as a code owner July 8, 2023 22:11
@koji koji requested review from brenthagen and removed request for a team July 8, 2023 22:11
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #13061 (19b9700) into edge (7341efe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13061   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files        2381     2381           
  Lines       65529    65529           
  Branches     7297     7297           
=======================================
  Hits        47475    47475           
  Misses      16322    16322           
  Partials     1732     1732           
Flag Coverage Δ
app 71.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@koji koji merged commit 4884dea into edge Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants