-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardware): added a script write and interact with the Flex eeprom. #13054
Conversation
fix an issue when reading properties from the eeprom
…line SODIMM_222 low when writting to the eeprom
deal with overflowing incomplete data cleaning up
…h for testing - removed hard while loops when parsing data - return set of PropertyId of the properties that were successfully written to the eeprom - dropped the manufacturing_facility and unique_id values from the serial number - removed unused PropertyId’s MACHINE_TYPE, MACHINE_VERSION, PROGRAMMED_DATE, UNIT_NUMBER - added MAX_DATA_LEN so we can limit the size of a property to 255 bytes - removed eeprom_writter.py script as this will be added in a separate pr - added unit tests
…em_hardware to return one item added defines to drivers.__init__ use gpiod passed down from ot3Controller when initializing the EEPROMDriver
return the EEPROMDriver module from the OT3Controller via a property fix the eeprom_build_driver module
added unit tests
Codecov Report
@@ Coverage Diff @@
## edge #13054 +/- ##
==========================================
- Coverage 72.34% 71.68% -0.66%
==========================================
Files 2379 1560 -819
Lines 65363 51427 -13936
Branches 7289 3256 -4033
==========================================
- Hits 47284 36868 -10416
+ Misses 16375 14077 -2298
+ Partials 1704 482 -1222
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eeprom_writer
not eeprom_writter
and some nits, ut otherwise looks good!
@@ -0,0 +1,293 @@ | |||
"""This script is able to read/write to/from the Flex EEPROM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: all of the detail about what arguments do should be in the argument help text instead of here so we don't have to write them twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We print out this module doc string using the doc variable as part of the argParser description whenever we pass in --help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but --help
will also print out the helpstring for each argument on its own, so itll be duplicated
raise errors instead of calling exit() add serial number format description only write FORMAT_VERSION if we have at least one other property to write
@vegano1 - Should there be a "print raw" - allowing us to just dump the raw eeprom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
Overview
We need to store the serial information for the Flex on the eeprom, this script will be used to write and verify that value along with any other data we might want to write to the eeprom.
Closes: RET-1347 & RET-1349
Test Plan
Changelog
Review requests
Risk assessment
Low