fix(app): prevent longpress to analysis failed protocol #13050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when longpressing, app needs to prevent displaying the modal
Codecov Report
@@ Coverage Diff @@
## edge #13050 +/- ##
=======================================
Coverage 72.28% 72.28%
=======================================
Files 2372 2372
Lines 65042 65042
Branches 7286 7286
=======================================
Hits 47015 47015
Misses 16324 16324
Partials 1703 1703
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
According to Mel, any interaction on that card should lead to that pop up asking them to delete it.
Test Plan
2-a. tap a failed protocol -> delete modal shows up
2-b. long press a failed protocol -> delete modal shows up
Changelog
Review requests
Risk assessment
low