Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware-testing): measure evaporation loss and update liquid height #13048

Conversation

andySigler
Copy link
Contributor

Overview

This PR uses the scale to calculate how mush water has evaporated during the test, then updates the estimated liquid-level for each trial.

Test Plan

Changelog

Review requests

Risk assessment

Verified

This commit was signed with the committer’s verified signature.
ADubhlaoich Alan Dooley
@andySigler andySigler requested a review from ryanthecoder July 5, 2023 19:33
@andySigler andySigler requested a review from a team as a code owner July 5, 2023 19:33
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #13048 (6131567) into edge (2249c7a) will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13048      +/-   ##
==========================================
- Coverage   72.28%   71.81%   -0.47%     
==========================================
  Files        2372     1553     -819     
  Lines       65042    50984   -14058     
  Branches     7286     3256    -4030     
==========================================
- Hits        47015    36616   -10399     
+ Misses      16324    13886    -2438     
+ Partials     1703      482    -1221     
Flag Coverage Δ
app 43.69% <ø> (-27.58%) ⬇️
protocol-designer 44.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 819 files with indirect coverage changes

@andySigler andySigler merged commit 0c787ba into edge Jul 6, 2023
@andySigler andySigler deleted the feat-hardware-testing-measure-evaporation-loss-to-calculate-liquid-height branch July 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants