Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add flex slot labels to protocol designer deck map #13047

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

brenthagen
Copy link
Contributor

Overview

adds flex slot labels to protocol designer deck setup map

Screen Shot 2023-07-05 at 1 55 18 PM

closes RAUT-526

Test Plan

manually verified existence and positioning of flex slot labels on deck setup page

Changelog

  • Adds flex slot labels to protocol designer deck setup map

Review requests

  • confirm existence and positioning of flex slot labels on deck setup page
  • should the slot labels be added anywhere else in PD?

Risk assessment

low

…ck map

adds flex slot labels to protocol designer deck setup map

closes RAUT-526
@brenthagen brenthagen requested review from shlokamin and jerader July 5, 2023 19:00
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEAUTIFUL 😍

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #13047 (4f67c98) into edge (8280fb0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13047   +/-   ##
=======================================
  Coverage   72.28%   72.28%           
=======================================
  Files        2372     2372           
  Lines       65040    65040           
  Branches     7284     7284           
=======================================
  Hits        47013    47013           
  Misses      16324    16324           
  Partials     1703     1703           
Flag Coverage Δ
protocol-designer 44.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otocol-designer/src/components/DeckSetup/index.tsx 22.22% <0.00%> (ø)

@brenthagen brenthagen merged commit f524c66 into edge Jul 5, 2023
@brenthagen brenthagen deleted the protocol-designer_deck-map-slot-labels branch July 5, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants