-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add retract_axis to OT-2 and FLEX hardware-control api #13001
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #13001 +/- ##
==========================================
Coverage 72.28% 72.28%
==========================================
Files 2373 1552 -821
Lines 65064 50630 -14434
Branches 7289 3256 -4033
==========================================
- Hits 47032 36600 -10432
+ Misses 16328 13548 -2780
+ Partials 1704 482 -1222
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, typo tho
@@ -1291,8 +1291,33 @@ async def retract( | |||
|
|||
Works regardless of critical point or home status. | |||
""" | |||
machine_ax = OT3Axis.by_mount(mount) | |||
await self._home((machine_ax,)) | |||
await self.restract_axis(OT3Axis.by_mount(mount)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await self.restract_axis(OT3Axis.by_mount(mount)) | |
await self.retract_axis(OT3Axis.by_mount(mount)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this along with #13006 (without app changes) on an OT3 and confirmed that axis retraction works. The only issue observed was that motion planning doesn't seem to know that the axis is already at its highest and doesn't need to move to a different point to clear all labware on deck. Pretty sure that's on the engine so will confirm and get back to you so we can merge this PR in.
Alright, verified that fixing this issue required only a protocol engine change. |
Addresses hardware-control side of RQA-997
Protocol engine & app changes will follow in #13006
Overview
Adds per-axis retraction feature to hardware controller API for OT2 & Flex
Test Plan
Test on OT2 & Flex and make sure the axes retract correctly. Also make sure mount retraction remains unchanged.
Changelog
retract_axis
HC api methods and updated mount retraction to delegate to the new methodReview requests
Risk assessment
Low