fix(app): fix Touchscreen Sleep scrolling issue #12992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tap Sleep settting, the touchscreen app display the top
Codecov Report
@@ Coverage Diff @@
## edge #12992 +/- ##
=======================================
Coverage 72.54% 72.54%
=======================================
Files 1542 1542
Lines 50521 50521
Branches 3180 3180
=======================================
Hits 36649 36649
Misses 13394 13394
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. |
ewagoner
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tap Sleep settting, the touchscreen app display the top
Overview
before
https://github.com/Opentrons/opentrons/assets/474225/e3373f4e-1318-4bf4-a2a1-2def9cb3258c
after
https://github.com/Opentrons/opentrons/assets/474225/6f260e4c-a2c4-4d24-9efe-06e5ed964ea9
Test Plan
The app shows the screen's title without scrolling
Changelog
Review requests
Risk assessment
low