Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): look for ok gripper #12991

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Jun 27, 2023

Overview

I am accidentally looking for a !ok gripper instead of an ok gripper so it wasn't showing up in the app when attached

@smb2268 smb2268 requested a review from TamarZanzouri June 27, 2023 15:50
@smb2268 smb2268 self-assigned this Jun 27, 2023
@smb2268 smb2268 requested a review from a team as a code owner June 27, 2023 15:50
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #12991 (61b1776) into internal-release_0.13.0 (b648555) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           internal-release_0.13.0   #12991      +/-   ##
===========================================================
- Coverage                    73.28%   73.28%   -0.01%     
===========================================================
  Files                         2337     2337              
  Lines                        63700    63700              
  Branches                      7026     7026              
===========================================================
- Hits                         46684    46682       -2     
- Misses                       15355    15356       +1     
- Partials                      1661     1662       +1     
Flag Coverage Δ
app 71.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pp/src/organisms/Devices/InstrumentsAndModules.tsx 78.37% <100.00%> (ø)

... and 1 file with indirect coverage changes

@smb2268 smb2268 changed the base branch from edge to internal-release_0.13.0 June 27, 2023 16:14
@smb2268 smb2268 requested review from a team as code owners June 27, 2023 16:14
@smb2268 smb2268 force-pushed the app_fix-null-gripper branch from 5e538d3 to 61b1776 Compare June 27, 2023 16:15
@smb2268 smb2268 merged commit caa53c6 into internal-release_0.13.0 Jun 27, 2023
@smb2268 smb2268 deleted the app_fix-null-gripper branch June 27, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants