Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api, hardware-testing): update plunger speed/currents #12987

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

andySigler
Copy link
Contributor

Overview

  • 96ch plunger max-speed increased from 5 to 15 mm/sec
  • 96ch plunger run-current decreased from 2.2 to 0.8 amps (because of resonance)
  • 1/8ch plunger max-speed increased from 45 to 70 mm/sec

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested review from a team as code owners June 27, 2023 02:11
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #12987 (c6c663d) into edge (b648555) will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12987      +/-   ##
==========================================
- Coverage   73.28%   72.85%   -0.43%     
==========================================
  Files        2337     2358      +21     
  Lines       63700    64351     +651     
  Branches     7026     7171     +145     
==========================================
+ Hits        46684    46885     +201     
- Misses      15355    15787     +432     
- Partials     1661     1679      +18     
Flag Coverage Δ
app 71.46% <ø> (ø)
g-code-testing 96.44% <ø> (ø)
protocol-designer 44.44% <ø> (-1.91%) ⬇️
shared-data 76.64% <ø> (+1.01%) ⬆️
step-generation 85.91% <ø> (-2.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/opentrons/config/defaults_ot3.py 100.00% <ø> (ø)

... and 86 files with indirect coverage changes

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also edit the run current in the 96 channel general definition for the v2 configs?

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, cool!

Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@andySigler andySigler merged commit 4b2cd5c into edge Jun 27, 2023
@andySigler andySigler deleted the update-96ch-plunger-current-and-speed branch June 27, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants