-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api, hardware-testing): update plunger speed/currents #12987
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #12987 +/- ##
==========================================
- Coverage 73.28% 72.85% -0.43%
==========================================
Files 2337 2358 +21
Lines 63700 64351 +651
Branches 7026 7171 +145
==========================================
+ Hits 46684 46885 +201
- Misses 15355 15787 +432
- Partials 1661 1679 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also edit the run current in the 96 channel general
definition for the v2 configs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
Overview
5
to15
mm/sec2.2
to0.8
amps (because of resonance)45
to70
mm/secTest Plan
Changelog
Review requests
Risk assessment