fix(app): update ODD unfinished route path when update not necessary #12975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #12975 +/- ##
==========================================
- Coverage 72.87% 72.47% -0.40%
==========================================
Files 2351 1544 -807
Lines 64461 50538 -13923
Branches 7190 3203 -3987
==========================================
- Hits 46973 36628 -10345
+ Misses 15805 13426 -2379
+ Partials 1683 484 -1199
Flags with carried forward coverage won't be shown. Click here to find out more. |
koji
reviewed
Jun 26, 2023
|
|
||
| export function NoUpdateFound(): JSX.Element { | ||
| const { i18n, t } = useTranslation(['device_settings', 'shared']) | ||
| const history = useHistory() | ||
| const dispatch = useDispatch() |
There was a problem hiding this comment.
import type { Dispatch } from '../../redux/types'
Suggested change
| const dispatch = useDispatch() | |
| const dispatch = useDispatch<Dispatch>() |
koji
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the unboxing flow unfinished route path when an update is not necessary. This fixes a bug where the welcome screen always showed up if you completed the unboxing flow without needing to update robot software.
Risk assessment
Low