fix(app): update software keyboard css to aling with dqa #12940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the index.css under software keyboard fix RAUT-497
Codecov Report
@@ Coverage Diff @@
## edge #12940 +/- ##
========================================
Coverage 72.88% 72.89%
========================================
Files 2342 2345 +3
Lines 64208 64411 +203
Branches 7127 7227 +100
========================================
+ Hits 46799 46952 +153
- Misses 15741 15775 +34
- Partials 1668 1684 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
brenthagen
approved these changes
Jun 21, 2023
| background-color: #d0d0d0; | ||
| font-family: 'Public Sans', sans-serif; | ||
| padding: 8px; | ||
| font-size: 28px; | ||
| } | ||
|
|
||
| .simple-keyboard.oddTheme1 .hg-row .hg-button:not(:last-child) { |
There was a problem hiding this comment.
should this also be .hg-row:not(:last-child)? without, the numpad has extra bottom margin also:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update the index.css under software keyboard
fix RAUT-497
updated_keyboard.mov
Test Plan
Changelog
Review requests
Risk assessment
low