Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): Updated accuracy functions for p50 and p1000 single channels #12760

Conversation

andySigler
Copy link
Contributor

@andySigler andySigler commented May 22, 2023

Overview

Accuracy lookup tables are updated based on testing from DVT single channels, both P50 and P1000 models.

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested a review from ryanthecoder May 22, 2023 20:11
@ryanthecoder ryanthecoder force-pushed the feat-shared-data-updated-single-channel-functions-dvt-1 branch from 9597fcd to 40d3731 Compare May 22, 2023 20:16
@ryanthecoder ryanthecoder requested a review from a team as a code owner May 22, 2023 20:16
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfoster1 sfoster1 changed the base branch from edge to internal-release_0.9.0 May 22, 2023 20:31
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #12760 (40d3731) into internal-release_0.9.0 (bdb8c66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           internal-release_0.9.0   #12760   +/-   ##
=======================================================
  Coverage                   73.13%   73.13%           
=======================================================
  Files                        1511     1511           
  Lines                       49567    49567           
  Branches                     3028     3028           
=======================================================
  Hits                        36252    36252           
  Misses                      12852    12852           
  Partials                      463      463           
Flag Coverage Δ
app 44.20% <ø> (ø)
protocol-designer 46.35% <ø> (ø)
shared-data 75.43% <ø> (ø)
step-generation 88.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sfoster1 sfoster1 merged commit 92e65e5 into internal-release_0.9.0 May 22, 2023
@sfoster1 sfoster1 deleted the feat-shared-data-updated-single-channel-functions-dvt-1 branch May 22, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants