fix(api): add a buffer to tip action home moves to make sure the limit switch is triggered #12743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During pick up and drop tip movements on the 96 channel, we move the motor exactly the same distance as we do back to the home position. Strangely, these are also the only moves that seem to not be able to reset their position on a commanded home message.
There was another issue (resolved by Opentrons/ot3-firmware#669) which I think was probably a red herring for the 'resetting from home' position issue.
Test Plan
Changelog
Review requests
Does this solution seem OK for now? Also I know we need to do something with the floating hardcoded values in the
pipette_handler
, but decided to not address that here.Risk assessment
Low. Just adding a buffer for homing moves on the tip motors for the 96 channel.