Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Home pipette used correct gantry load settings #12742

Merged

Conversation

andySigler
Copy link
Contributor

Overview

OT3API passes in the currently active GantryLoad when calling OT3Controller.home(), so that correct homing speeds are used.

Test Plan

Changelog

Review requests

Risk assessment

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #12742 (fd1f015) into edge (a14cdd6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12742   +/-   ##
=======================================
  Coverage   73.43%   73.43%           
=======================================
  Files        2291     2291           
  Lines       62857    62851    -6     
  Branches     6777     6777           
=======================================
- Hits        46159    46157    -2     
+ Misses      15082    15078    -4     
  Partials     1616     1616           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entrons/hardware_control/backends/ot3controller.py 66.81% <ø> (+1.00%) ⬆️
...pentrons/hardware_control/backends/ot3simulator.py 87.87% <ø> (-0.10%) ⬇️
api/src/opentrons/hardware_control/ot3api.py 79.37% <ø> (ø)

@andySigler andySigler force-pushed the fix-api-home-pipette-used-correct-gantry-load-settings branch from f90b769 to fd1f015 Compare May 19, 2023 17:30
@andySigler andySigler marked this pull request as ready for review May 19, 2023 17:34
@andySigler andySigler requested a review from a team as a code owner May 19, 2023 17:34
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@andySigler andySigler merged commit 5884a41 into edge May 19, 2023
@andySigler andySigler deleted the fix-api-home-pipette-used-correct-gantry-load-settings branch May 19, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants