fix(step-generation): modify curried command order for heater-shaker #12741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-453
bug somewhat outlined here: https://opentrons.atlassian.net/browse/RESC-134
Overview
Change curried command order for heater-shaker so that the open latch command occurs at the end of the sequence, after the shake and heat commands. And only deactivate the shake if the H-S is already in motion
Test Plan
Test this on a heater-shaker. I also confirmed that the protocol in the support ticket passed protocol analysis in the app after reimporting and exporting to PD with this change.
Changelog
changed the order of curried command creator in
heaterShaker
and add some logic so deactivating the shaker only occurs when the heater shaker is already in motion.Review requests
see test plan
Risk assessment
low