Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(step-generation): modify curried command order for heater-shaker #12741

Merged
merged 3 commits into from
May 22, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented May 19, 2023

closes RAUT-453

bug somewhat outlined here: https://opentrons.atlassian.net/browse/RESC-134

Overview

Change curried command order for heater-shaker so that the open latch command occurs at the end of the sequence, after the shake and heat commands. And only deactivate the shake if the H-S is already in motion

Test Plan

Test this on a heater-shaker. I also confirmed that the protocol in the support ticket passed protocol analysis in the app after reimporting and exporting to PD with this change.

Changelog

changed the order of curried command creator in heaterShaker and add some logic so deactivating the shaker only occurs when the heater shaker is already in motion.

Review requests

see test plan

Risk assessment

low

@jerader jerader marked this pull request as ready for review May 19, 2023 13:28
@jerader jerader requested a review from a team as a code owner May 19, 2023 13:28
@jerader jerader requested review from shlokamin and sanni-t May 19, 2023 13:29
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #12741 (3725268) into edge (a14cdd6) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12741   +/-   ##
=======================================
  Coverage   73.43%   73.44%           
=======================================
  Files        2291     2291           
  Lines       62857    62860    +3     
  Branches     6777     6780    +3     
=======================================
+ Hits        46159    46167    +8     
+ Misses      15082    15078    -4     
+ Partials     1616     1615    -1     
Flag Coverage Δ
protocol-designer 46.35% <ø> (ø)
step-generation 88.64% <66.66%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ation/src/commandCreators/compound/heaterShaker.ts 76.92% <66.66%> (+16.05%) ⬆️

... and 1 file with indirect coverage changes

@jerader jerader requested review from rwarshauer and removed request for a team May 19, 2023 15:27
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jerader this looks right to me! i think it would be worth adding a test in the HS compound command creator tho, im honestly surprised this didn't break any of them 🤔

@jerader jerader merged commit acbf638 into edge May 22, 2023
@jerader jerader deleted the pd_hs-deactivate-shaker-bug branch May 22, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants