fix(app): fix view error details does nothing

[koji]

Overview

[design]
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr/Release%3A-Opentrons-Flex-Touchscreen-Designs?type=design&node-id=8860-128824&t=SE4QZemOanWChb3k-0

hook RunFailedModal to the view error details button in RunSummary and update the modal itself since the size and content were updated recently.

going to the option 1
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr?node-id=8963:248012#447508536

Will be updated if the design is changed.

close RQA-814

Test Plan

• run a protocol which will be failed
• tap view error details button

Changelog

• update RunFaildModal (removed red frame)
• add RunFailedModal to RunSummary component

Review requests

Currently errorType in Error: errorType is empty since errorType we can retrieve doesn't represent the entire errors.
Should we display the first error's errorType? eg runRecord.data.errors[0].errorType?

Risk assessment

low

[codecov]

Codecov Report

Merging #12732 (109bdeb) into edge (61a3290) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             edge   #12732      +/-   ##
==========================================
- Coverage   73.43%   73.37%   -0.07%     
==========================================
  Files        2291     2292       +1     
  Lines       62861    63326     +465     
  Branches     6775     6969     +194     
==========================================
+ Hits        46163    46464     +301     
- Misses      15082    15217     +135     
- Partials     1616     1645      +29     

Flag	Coverage Δ
app	71.51% <25.00%> (-0.25%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/src/pages/OnDeviceDisplay/RunSummary.tsx	13.20% <0.00%> (-0.52%)	⬇️
...OnDeviceDisplay/RunningProtocol/RunFailedModal.tsx	80.00% <100.00%> (-2.36%)	⬇️

... and 34 files with indirect coverage changes

[shlokamin]

errorType is already returned from the runs endpoint right? we should already have it inside of the errorType prop in RunError:

interface RunError {
  id: string
  errorType: string
  createdAt: string
  detail: string
}

[koji]

But it doesn't represented the entire error.

[koji]

in the Desktop app, errorType isn't used but just parse errors[] and display details.

For this modal errorType came from a new error endpoint. Actually, I posted that current errorType that we can display doesn't represent the entire errors. But the design hasn't been update.

We can display errorType from the errors[0].details but I guess that may cause confusion because if there are more than 2 error details, a couple of errors might not related to the errorType completely.

[shlokamin]

i believe the only data we might get that dosent yet exist is the error code (cc @fsinapi).

let's sync on this during standup and try to get this merged before the afternoon

[shlokamin]

the backend won't ever give us a top level error type — global error state was cut from scope. i updated the component to show the first error type in the list of errors for now. just verified with @sanni-t that this should give users sufficient info

[shlokamin]

i can't seem to get the error modal to render because i get redirected to the robot dashboard when i cancel the run. i think that might be because of the TopLevelRedirects brian and i added... ill look into it though

[koji]

i can't seem to get the error modal to render because i get redirected to the robot dashboard when i cancel the run. i think that might be because of the TopLevelRedirects brian and i added... ill look into it though

hmm, on my end I could open the modal...