fix(app): only prepare stored protocols in ChooseProtocolSlideout once slid out #12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-cooper
requested review from
TamarZanzouri,
shlokamin and
a team
and removed request for
a team and
TamarZanzouri
Codecov Report
@@ Coverage Diff @@
## edge #12721 +/- ##
=======================================
Coverage 73.36% 73.36%
=======================================
Files 2264 2264
Lines 61507 61513 +6
Branches 6788 6789 +1
=======================================
+ Hits 45125 45132 +7
+ Misses 14762 14760 -2
- Partials 1620 1621 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This should drastically improve the load time of the devices landing page on the desktop app. Especially in cases where there are many stored protocols and/or many discovered robots
Risk assessment
low