feat(app): error handling for wrong pip attached #12706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
koji,
smb2268 and
a team
and removed request for
a team and
koji
Codecov Report
@@ Coverage Diff @@
## edge #12706 +/- ##
==========================================
+ Coverage 73.35% 73.39% +0.04%
==========================================
Files 2261 2265 +4
Lines 61480 61971 +491
Branches 6782 6984 +202
==========================================
+ Hits 45098 45486 +388
- Misses 14763 14831 +68
- Partials 1619 1654 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
force-pushed
the
app_pip-flow-wrong-insturment-attached
branch
from
ebd1d1b to
87f1c47
Compare
smb2268
requested changes
May 16, 2023
| @@ -94,7 +112,9 @@ export const Results = (props: ResultsProps): JSX.Element => { | |||
| } | |||
|
|
|||
| const handleProceed = (): void => { | |||
| if (currentStepIndex === totalStepCount || !isSuccess) { | |||
| if (requiredPipette != null && Boolean(!isCorrectPipette)) { | |||
| goBack() | |||
There was a problem hiding this comment.
This takes us back to the before you begin screen which I'm not sure makes sense from a user perspective - on the OT-2 flows we just have the CheckPipetteButton here in this case, so we recheck for attachment of the correct pipette instead of rerouting the user through the flow again which might make more sense?
There was a problem hiding this comment.
I wonder if we should add a subheader that says which pipette is the correct one to attach?
jerader
force-pushed
the
app_pip-flow-wrong-insturment-attached
branch
from
ab91f60 to
91f7f03
Compare
smb2268
approved these changes
May 19, 2023
| /> | ||
| ) | ||
| } | ||
| if ( |
There was a problem hiding this comment.
can we make this an else if?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RLIQ-393
Overview
When attaching a pipette in run setup, if you attach the wrong pipette, the results page now renders the error modal (designs). When you click
detach and retryit goes back to detach and reattach the correct pipette.Test Plan
test this flow on a robot to make sure it works as expected
Changelog
Resultspage and add test casesReview requests
see test plan
Risk assessment
low