Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware-testing): 1ul and 8ch fully implemented #12699

Merged
merged 46 commits into from
May 16, 2023

Conversation

andySigler
Copy link
Contributor

Overview

Merging latest changes from gravimetric testing back into edge. Changes include:

  • Adding separate liquid classes for different models of pipette
  • Tuning Z speed
  • Separate 8ch Protocol files for --increment vs normal QC test, so they can use different labware
  • More tuning changes to liquid class defaults

Test Plan

Changelog

Review requests

Risk assessment

andySigler and others added 30 commits March 22, 2023 23:08
…gle (#12574)

* Update the increment function

* add spaces

---------

Co-authored-by: jerome <[email protected]>
@andySigler andySigler requested a review from a team as a code owner May 15, 2023 13:45
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #12699 (f9b013e) into edge (e2ce496) will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12699      +/-   ##
==========================================
+ Coverage   73.54%   74.10%   +0.56%     
==========================================
  Files        2283     2234      -49     
  Lines       62663    61375    -1288     
  Branches     6718     6540     -178     
==========================================
- Hits        46084    45482     -602     
+ Misses      14977    14311     -666     
+ Partials     1602     1582      -20     
Flag Coverage Δ
app 74.61% <ø> (+2.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 49 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, nice!

@andySigler andySigler merged commit 7f205c5 into edge May 16, 2023
@andySigler andySigler deleted the feat-hardware-testing-1ul-and-multi-fully-implemented branch May 16, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants