Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): do not poll protocol analyses on device page #12641

Merged

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented May 4, 2023

Overview

This PR removes a call to a hook that was polling the protocol analyses endpoints from the device page. This was causing the robot to stall and appear unresponsive.

Changelog

  • do not poll protocol analyses on device page

Review requests

Go to the internal releases robot in the office and make sure we are no longer spamming the protocol analyses endpoints anymore

Risk assessment

Low

@shlokamin shlokamin changed the base branch from edge to internal-release_0.6.0 May 4, 2023 21:01
@shlokamin shlokamin changed the title fix(app): do not poll analyses on device page fix(app): do not poll protocol analyses on device page May 4, 2023
@shlokamin shlokamin requested review from sfoster1 and b-cooper May 4, 2023 21:04
@shlokamin shlokamin marked this pull request as ready for review May 4, 2023 21:04
@shlokamin shlokamin requested a review from a team as a code owner May 4, 2023 21:04
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #12641 (c912ca1) into internal-release_0.6.0 (337947e) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           internal-release_0.6.0   #12641      +/-   ##
==========================================================
- Coverage                   73.54%   73.29%   -0.25%     
==========================================================
  Files                        2270     1506     -764     
  Lines                       62412    49349   -13063     
  Branches                     6619     2997    -3622     
==========================================================
- Hits                        45898    36171    -9727     
+ Misses                      14937    12721    -2216     
+ Partials                     1577      457    -1120     
Flag Coverage Δ
app 46.77% <ø> (-25.24%) ⬇️
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 765 files with indirect coverage changes

@sfoster1 sfoster1 merged commit 45af224 into internal-release_0.6.0 May 4, 2023
@sfoster1 sfoster1 deleted the app_do-not-poll-analyses-on-device-page branch May 4, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants