Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): binary search calibration tuning #12588

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

fsinapi
Copy link
Contributor

@fsinapi fsinapi commented Apr 28, 2023

Overview

This PR changes a couple of settings for automated binary search calibration to improve reliability

  • The speed when moving between points is lowered to a default of 50mm/s to reduce shaking on the calibration tip
  • The initial tolerance & number of iterations is changed to increase the total tolerance of the final verification of the edge
    • The old settings had a final check tolerance of +/- 0.03125mm, which would result in the software thinking the edge was invalid
    • The new settings give a tolerance of +/- 0.09375mm which is very close to our actual tolerance limit of 0.1mm

Test Plan

Test calibration on a robot + pipette that had been failing calibration. It works goodly now.

Changelog

Review requests

Risk assessment

lo

@fsinapi fsinapi requested a review from sfoster1 April 28, 2023 16:02
@fsinapi fsinapi requested a review from a team as a code owner April 28, 2023 16:02
@fsinapi fsinapi self-assigned this Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #12588 (e3f0451) into internal-release_0.5.0 (fc09e2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           internal-release_0.5.0   #12588   +/-   ##
=======================================================
  Coverage                   73.59%   73.59%           
=======================================================
  Files                        2246     2246           
  Lines                       61830    61830           
  Branches                     6480     6480           
=======================================================
  Hits                        45504    45504           
  Misses                      14757    14757           
  Partials                     1569     1569           
Flag Coverage Δ
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/opentrons/config/defaults_ot3.py 97.36% <ø> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the numbers... are good

@fsinapi fsinapi merged commit 688e35c into internal-release_0.5.0 Apr 28, 2023
@fsinapi fsinapi deleted the binary_search_settings_fix branch April 28, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants