Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): don't send a stop on an unrecoverable error #12555

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

ryanthecoder
Copy link
Contributor

Overview

This causes a ton of stop requests to get spit out when a estop is detected

Test Plan

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner April 24, 2023 18:47
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me; we may want this back but we definitely do not want it down at the canbus level, issues like this can only be solved at a higher level with more understanding of context.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (edge@970036b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6a5c10e differs from pull request most recent head 3f72ea7. Consider uploading reports for the commit 3f72ea7 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12555   +/-   ##
=======================================
  Coverage        ?   73.30%           
=======================================
  Files           ?     1506           
  Lines           ?    49349           
  Branches        ?     2997           
=======================================
  Hits            ?    36175           
  Misses          ?    12718           
  Partials        ?      456           
Flag Coverage Δ
notify-server 89.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pentrons_hardware/drivers/can_bus/can_messenger.py 93.14% <ø> (ø)

@ryanthecoder ryanthecoder merged commit f232ebc into edge Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants