fix(api): always validate edge during OT3 calibration #12552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ae1fa2 changed calibration z height checking to use numpy.isclose, but this isn't a sufficient check: we also want to catch the detected height < minimum height. We might overrun, and certainly unit tests are expecting this to be caught. In addition, an old test needed to be updated for new structure.
Codecov Report
@@ Coverage Diff @@
## edge #12552 +/- ##
=======================================
Coverage 73.57% 73.57%
=======================================
Files 2266 2266
Lines 62371 62371
Branches 6587 6587
=======================================
Hits 45891 45891
Misses 14917 14917
Partials 1563 1563
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per hardware team's request, it should be the default behavior to validate the found edge each time and raise an error when the edge cannot be validated.