Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): Add backwards compatible pipettes to new pipette configurations #12514

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

Laura-Danielle
Copy link
Contributor

@Laura-Danielle Laura-Danielle commented Apr 18, 2023

Overview

To support fully transitioning to the new pip schema on the app side, we need to include the list of backwards compatible pipettes which is used to detect whether a pipette attached to the robot can be used as a replacement for the pipette specified.

Eventually this key will want to just be a volume range once we support loading pipettes by volume/channels.

I also took the opportunity to remove some migration stuff from the build_json script since we will not need to use that moving forward.

Test Plan

  • Throw this on a robot and make sure you can still successfully load supported pipettes in a protocol on a Flex.

@Laura-Danielle Laura-Danielle requested a review from a team as a code owner April 18, 2023 16:49
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #12514 (07e5229) into edge (85d9161) will increase coverage by 0.08%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12514      +/-   ##
==========================================
+ Coverage   73.58%   73.67%   +0.08%     
==========================================
  Files        2255     2261       +6     
  Lines       62142    62277     +135     
  Branches     6514     6581      +67     
==========================================
+ Hits        45729    45883     +154     
+ Misses      14855    14831      -24     
- Partials     1558     1563       +5     
Flag Coverage Δ
app 72.40% <ø> (+0.12%) ⬆️
notify-server 89.13% <ø> (ø)
protocol-designer 46.34% <ø> (ø)
shared-data 75.35% <10.00%> (+2.05%) ⬆️
step-generation 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s_shared_data/pipette/scripts/build_json_script.py 0.00% <0.00%> (ø)
...pentrons_shared_data/pipette/pipette_definition.py 92.18% <100.00%> (+0.06%) ⬆️

... and 39 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@sfoster1
Copy link
Member

With that last commit, works on a flex

@Laura-Danielle
Copy link
Contributor Author

makes sense to me @sfoster1

@sfoster1 sfoster1 merged commit ba67b77 into edge Apr 24, 2023
@sfoster1 sfoster1 deleted the add_backcompat_names_shared_data branch April 24, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants