feat(odd): robot dashboard recently run protocols #12490
Conversation
- create EmptyRecentRun component - change the folder name under asset from odd to OnDeviceDisplay - update paths in components
…m/Opentrons/opentrons into feat_update-robotdashboard-design
jerader
requested review from
brenthagen,
ewagoner,
koji and
shlokamin
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## edge #12490 +/- ##
==========================================
+ Coverage 73.67% 73.69% +0.02%
==========================================
Files 2252 2257 +5
Lines 61976 62388 +412
Branches 6517 6693 +176
==========================================
+ Hits 45658 45976 +318
- Misses 14757 14822 +65
- Partials 1561 1590 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| "missing_module": "missing {{num}} module", | ||
| "missing_module_plural": "missing {{num}} modules", | ||
| "missing_pipette": "missing {{num}} pipette", | ||
| "missing_pipettes_plural": "missing {{num}} pipettes", | ||
| "missing_both": "missing {{numMod}} module(s) and {{numPip}} pipette(s)" |
There was a problem hiding this comment.
no idea what correct copy is supposed to be here so for now, i made the decision to pluralize some of them
|
I was too lazy... Seems that Robot Dashboard needs carousel.
|
| @@ -0,0 +1,26 @@ | |||
| import * as React from 'react' | |||
There was a problem hiding this comment.
@jerader I updated the test a little bit.
- add the image name check
- remove MemoryRoute
…m/Opentrons/opentrons into feat_update-robotdashboard-design
@koji, nice catch, thank you! |
| }, | ||
| ], | ||
| } as any | ||
|
|
There was a problem hiding this comment.
I only created a test for useMissingProtocolHardware but there should be tests made for useRequiredProtocolHardware and useRequiredProtocolLabware. Maybe can be done in a followup PR.
There was a problem hiding this comment.
I added tests for useRequiredProtocolLabware.
So we will need to add useRequiredProtocolHardware.
|
|
app/src/organisms/OnDeviceDisplay/RobotDashboard/EmptyRecentRun.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/OnDeviceDisplay/RobotDashboard/RecentProtocolRunCard.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/OnDeviceDisplay/RobotDashboard/RecentProtocolRunCard.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/OnDeviceDisplay/RobotDashboard/RecentProtocolRunCard.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/OnDeviceDisplay/RobotDashboard/RecentProtocolRunCard.tsx
Outdated
Show resolved
Hide resolved
|
The name truncation isn't quite working. Looks like the designs have an ellipses at the end rather than in the middle like we usually do. |
|
protocol name truncate issue has been resolved:
|
| -webkit-box-orient: vertical; | ||
| -webkit-line-clamp: 5; | ||
| overflow: hidden; | ||
| width: 100%; |
There was a problem hiding this comment.
@jerader thank you for the update.
I will update this style a little bit (remove unnecessary properties)
closes RCORE-559 RCORE-586
Overview
coAuthored with @koji
Creates
EmptyRecentRuns, andRecentRunProtocolCardinRobotDashboardso UI is wired up and changes depending on if you have recent runs or not.In terms of copy for
Missing, we are still waiting for Mel's feedback.thread on Slack
Currently
RecentRunProtocolCardis located under organisms since we get data via redux state and this component is used by the only one screen. If we need to use the component in somewhere, we can change the current implementation.Test Plan
Changelog
EmptyRecentRunand other misc assetsMiniCardButton- i think it is no longer needed but @koji can explain why he deleted it.MiniCardButtonwas for the old design and there is no similar button in hi-fi design, so it is no longer needed.lineHeightconstantsRecentRunCardtoRobotDashboard, with correct UIuseMissingProtocolHardwarethat takes inprotocolIdand spits out the hardware missing that is needed in the protocol.EmptyRecentRun,RobotDashboard, anduseMissingProtocolHardwareReview requests
Risk assessment
low