feat(odd): add run failed modal for running protocol #12483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add run failed modal for a failed run RCORE-563
Codecov Report
@@ Coverage Diff @@
## edge #12483 +/- ##
=======================================
Coverage 73.78% 73.78%
=======================================
Files 2247 2248 +1
Lines 61778 61805 +27
Branches 6452 6457 +5
=======================================
+ Hits 45580 45601 +21
- Misses 14678 14681 +3
- Partials 1520 1523 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
commented
Apr 12, 2023
| @@ -57,7 +57,7 @@ export function Modal(props: ModalProps): JSX.Element { | |||
| border={`0.375rem solid ${isError ? COLORS.red_two : COLORS.white}`} | |||
| width={modalWidth} | |||
| height="max-content" | |||
| maxHeight="32.5rem" | |||
| maxHeight="33.5rem" | |||
There was a problem hiding this comment.
Set the size of Run Failed's modal size
koji
commented
Apr 12, 2023
| @@ -23,7 +24,7 @@ export function ModalHeader(props: ModalHeaderProps): JSX.Element { | |||
| color={isError ? COLORS.white : COLORS.black} | |||
| height="6.25rem" | |||
| width="100%" | |||
| padding={SPACING.spacing6} | |||
| padding={isError ? SPACING.spacing5 : SPACING.spacing6} | |||
There was a problem hiding this comment.
isError: true padding 24px
isError: false padding 32px
I'm asking about this to Mel since less conditional statement in ui-component would make maintain easier.
ewagoner
reviewed
Apr 13, 2023
|
|
||
| if (errors == null) return null | ||
| const modalHeader: ModalHeaderBaseProps = { | ||
| title: 'Run failed', |
There was a problem hiding this comment.
Should this come from a translation file?
There was a problem hiding this comment.
yeah, you are right. I will update that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add run failed modal. When runStatus is failed, the app shows the modal.
The current modal is different from the design since we need a new error handling system to display the information in the Figma. This PR is using the first of errors from
run/${runId}. (Also error codes aren't defined yet.)When the system is ready, we will be able to align this modal with the design.
I comment out the event for
stopRunand I will follow up this with Shlok, Jesse, and Anthony.[design]
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr/Release%3A-Opentrons-Flex-Touchscreen-Designs?node-id=8860-128824&t=I3cn6xOFvLdgrX4y-0
close RCORE-563
Test Plan
Wait for a little bit and check the modal is showed up
Changelog
Review requests
Risk assessment
low