feat(api): expose versions of connected micros #12470
Merged
+116
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #12470 +/- ##
==========================================
- Coverage 73.81% 73.45% -0.36%
==========================================
Files 2246 1498 -748
Lines 61740 49150 -12590
Branches 6430 2991 -3439
==========================================
- Hits 45574 36104 -9470
+ Misses 14653 12590 -2063
+ Partials 1513 456 -1057
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Laura-Danielle
approved these changes
Apr 11, 2023
| @@ -68,6 +69,25 @@ | |||
| OT3SubSystem.gripper: NodeId.gripper, | |||
| } | |||
|
|
|||
| NODEID_SUBSYSTEM: Dict[NodeId, OT3SubSystem] = { | |||
| NodeId.gantry_x: OT3SubSystem.gantry_x, | |||
| NodeId.gantry_x_bootloader: OT3SubSystem.gantry_x, | |||
There was a problem hiding this comment.
I guess not super relevant to this PR, but should we be throwing an error somewhere in the hardware controller if one of the microcontrollers is in a bootloader state? Or, at the very least, should we not mask whether a node id is a bootloader?
There was a problem hiding this comment.
yes we should. i think we need to overhaul that at some point.
Implement the get_fw_version method of OT3API to return a stringified representation of all unique firmware versions for attached microcontrollers on the system. This is a not-great way of exposing this data programmatically, but this element is only used for display purposes so I think it's ok. In all normal cases (i.e. except during update) this will only return a single version. Closes RCORE-731
sfoster1
force-pushed
the
chore_add-fw-version-to-health
branch
from
434f27c to
62c5de3
Compare
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the get_fw_version method of OT3API to return a stringified representation of all unique firmware versions for attached microcontrollers on the system.
This is a not-great way of exposing this data programmatically, but this element is only used for display purposes so I think it's ok. In all normal cases (i.e. except during update) this will only return a single version.
Closes RCORE-731
Testing