Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware): add messages to fetch lifetime motor usage data #12464

Conversation

ryanthecoder
Copy link
Contributor

Overview

This adds two new can messages one for requesting motor lifetime usage and its response.

It also adds two helper scripts for the eeprom one to reset the values to default and one to dump the values to a hex file

Test Plan

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner April 10, 2023 19:17
@ryanthecoder ryanthecoder force-pushed the RLAB-291-use-eeprom-filesystem-to-store-stepper-motor-move-distance-data branch from f45a2be to 4bd92a1 Compare April 10, 2023 19:17
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #12464 (2e8b89c) into edge (d06eed1) will decrease coverage by 0.40%.
The diff coverage is 11.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12464      +/-   ##
==========================================
- Coverage   73.66%   73.27%   -0.40%     
==========================================
  Files        2252     1501     -751     
  Lines       61974    49356   -12618     
  Branches     6517     2991    -3526     
==========================================
- Hits        45656    36165    -9491     
+ Misses      14757    12735    -2022     
+ Partials     1561      456    -1105     
Flag Coverage Δ
app 46.85% <ø> (-25.41%) ⬇️
components 67.23% <ø> (ø)
hardware 58.82% <11.71%> (-0.43%) ⬇️
labware-library 49.74% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 46.34% <ø> (ø)
react-api-client 74.48% <ø> (ø)
step-generation 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns_hardware/firmware_bindings/messages/messages.py 91.66% <ø> (ø)
hardware/opentrons_hardware/scripts/dump_eeprom.py 0.00% <0.00%> (ø)
...ardware/opentrons_hardware/scripts/reset_eeprom.py 0.00% <0.00%> (ø)
.../opentrons_hardware/firmware_bindings/constants.py 100.00% <100.00%> (ø)
.../firmware_bindings/messages/message_definitions.py 98.59% <100.00%> (+0.03%) ⬆️
...ns_hardware/firmware_bindings/messages/payloads.py 99.25% <100.00%> (+<0.01%) ⬆️

... and 755 files with indirect coverage changes

@ryanthecoder ryanthecoder force-pushed the RLAB-291-use-eeprom-filesystem-to-store-stepper-motor-move-distance-data branch from 4bd92a1 to 81d534a Compare April 12, 2023 15:17
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -0,0 +1,150 @@
#!/usr/bin/env python3
"""blow away and reset EEPROM file systems."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌬️

@ryanthecoder ryanthecoder force-pushed the RLAB-291-use-eeprom-filesystem-to-store-stepper-motor-move-distance-data branch from 81d534a to 2e8b89c Compare April 14, 2023 15:46
@ryanthecoder ryanthecoder merged commit 4686354 into edge Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants