fix(app-shell-odd): make sure there is enough space on device before copying app tar file.

[vegano1]

Overview

If the scp or clean-up function failed for whatever reason, we would end up in a state where we did not have enough space on the system to scp the new app shell tar file. This pr will remove the tar file before attempting to scp the new one, in case it was not previously removed.

Test Plan

• test pushing file to odd
• cancel push midway and push file again

Changelog

• attempt to remove the old app shell tar file in case it was not previously removed.

Review requests

• test on ODD

Risk assessment

Low, flex work

[codecov]

Codecov Report

Merging #12461 (5e76da5) into edge (6af2495) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             edge   #12461      +/-   ##
==========================================
- Coverage   73.81%   73.78%   -0.03%     
==========================================
  Files        2241     2246       +5     
  Lines       61707    61905     +198     
  Branches     6420     6507      +87     
==========================================
+ Hits        45549    45679     +130     
- Misses      14650    14705      +55     
- Partials     1508     1521      +13     

Flag	Coverage Δ
app	72.50% <ø> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

[sfoster1]

lgtm!