-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): delete runs and protocols from ODD #12319
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #12319 +/- ##
==========================================
- Coverage 73.66% 73.65% -0.02%
==========================================
Files 2252 2252
Lines 61974 62019 +45
Branches 6517 6529 +12
==========================================
+ Hits 45656 45682 +26
- Misses 14757 14764 +7
- Partials 1561 1573 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ons/opentrons into app_delete-runs-and-protocols-ODD
|
||
export function LongPressModal(props: { | ||
longpress: UseLongPressResult | ||
protocol: ProtocolResource | ||
protocolId: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long press modal was only ever using the protocol id, it didn't need the whole protocol resource object
@@ -128,6 +142,7 @@ export function LongPressModal(props: { | |||
height="4.875rem" | |||
padding={SPACING.spacing5} | |||
onClick={handleRunClick} | |||
as="button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added these button tags for for accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
@@ -18,7 +18,14 @@ export interface ProtocolMetadata { | |||
} | |||
|
|||
export interface Protocol { | |||
links?: ResourceLinks | |||
links?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This typing change seems to be a more specific definition of what was already there, not necessarily something new. It's a pretty foundational change, though, since Protocol
is used so much. What are the implications for it, and should ResourceLinks
itself get changed to match, since it's used in this file by ProtocolAnalyses
and Protocols
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource links on the server side are typed per route. when we implemented types on the frontend we just made a generic type and shared it across all endpoints. so the Protocols
type that gets retuned from the /protocols
endpoint wont have this same interface
Overview
This PR enables users to delete protocols from the ODD. In order to do this, we must first delete a protocol's associated run ids.
Note: still need to add a loading state but waiting for designs.
closes RCORE-364, RCORE-365
Test Plan
Review requests
Delete a protocol from the long press modal + protocol details page and make sure the protocol actually gets deleted
Risk assessment
Low