From 95a656fe0f5f91b4500ad1ee46b901c7b2503be5 Mon Sep 17 00:00:00 2001
From: Nick Diehl <47604184+ncdiehl11@users.noreply.github.com>
Date: Tue, 27 Aug 2024 17:30:22 -0400
Subject: [PATCH] fix(app): filter robots for CSV protocols that raise analysis
 errors (#16145)

We are intentionally permissive of robots on which to start protocol
setup if analysis fails app-side. However, we previously checked whether
the analysis contained errors to make this determination. Given that CSV
parameter protocols raise analysis errors intentionally, but contain
useful information regarding the robot type, we should filter robots if
the analysis result is `parameter-value-required`.

Closes RQA-3114
---
 app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx b/app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx
index f16371f6aa4..0b145340852 100644
--- a/app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx
+++ b/app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx
@@ -204,9 +204,9 @@ export function ChooseRobotToRunProtocolSlideoutComponent(
     first(srcFileNames) ??
     protocolKey
 
-  // intentionally show both robot types if analysis has any error
+  // intentionally show both robot types if analysis fails
   const robotType =
-    mostRecentAnalysis != null && mostRecentAnalysis.errors.length === 0
+    mostRecentAnalysis != null && mostRecentAnalysis.result !== 'not-ok'
       ? mostRecentAnalysis?.robotType ?? null
       : null