From 231cde15118b52a392f5996fcdc0e1b51ef9daea Mon Sep 17 00:00:00 2001 From: Brent Hagen Date: Tue, 16 Apr 2024 14:21:39 -0400 Subject: [PATCH] refactor(api,app): remove internal_only flag from enableOEMMode setting (#14920) enableOEMMode isn't really an internal_only setting, and we need it included in the robot settings api response. change needed for the ODD text to anonymize and the factory mode toggle to work. originally part of oem-mode-integration branch. --- api/src/opentrons/config/advanced_settings.py | 5 ----- .../Devices/RobotSettings/RobotSettingsFeatureFlags.tsx | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/api/src/opentrons/config/advanced_settings.py b/api/src/opentrons/config/advanced_settings.py index 4d83d8ed1af..6a6076a8432 100644 --- a/api/src/opentrons/config/advanced_settings.py +++ b/api/src/opentrons/config/advanced_settings.py @@ -238,11 +238,6 @@ class Setting(NamedTuple): title="Enable OEM Mode", description="This setting anonymizes Opentrons branding in the ODD app.", robot_type=[RobotTypeEnum.FLEX], - show_if=( - "enableOEMMode", - True, - ), - internal_only=True, ), SettingDefinition( _id="enablePerformanceMetrics", diff --git a/app/src/organisms/Devices/RobotSettings/RobotSettingsFeatureFlags.tsx b/app/src/organisms/Devices/RobotSettings/RobotSettingsFeatureFlags.tsx index 80ed8a04f5b..9837c314ac3 100644 --- a/app/src/organisms/Devices/RobotSettings/RobotSettingsFeatureFlags.tsx +++ b/app/src/organisms/Devices/RobotSettings/RobotSettingsFeatureFlags.tsx @@ -29,6 +29,7 @@ interface RobotSettingsFeatureFlagsProps { const NON_FEATURE_FLAG_SETTINGS = [ 'enableDoorSafetySwitch', + 'enableOEMMode', 'disableHomeOnBoot', 'deckCalibrationDots', 'shortFixedTrash',