From 02236b39b38a048d2231e620289538aae465ac10 Mon Sep 17 00:00:00 2001
From: Seth Foster <seth@opentrons.com>
Date: Thu, 24 Oct 2024 11:53:29 -0400
Subject: [PATCH] chore: fix github workflow and failing tests (#16593)

Messed up the app test workflow so it wasn't running and therefore we
didn't notice some tests were failing. Fix the workflow, fix the tests.

Only changes of note are that vitest doesn't support baseline 2023
copying array reorder functions for some reason so replace them with
equivalents.
---
 .github/workflows/app-test-build-deploy.yaml         |  2 +-
 .../hooks/useHistoricRunDetails.ts                   | 12 +++++++-----
 app/src/pages/ODD/RobotDashboard/index.tsx           |  3 +--
 app/src/redux/config/__tests__/config.test.ts        |  2 ++
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/app-test-build-deploy.yaml b/.github/workflows/app-test-build-deploy.yaml
index d3c03e1f500..f0bfe7d8946 100644
--- a/.github/workflows/app-test-build-deploy.yaml
+++ b/.github/workflows/app-test-build-deploy.yaml
@@ -148,7 +148,7 @@ jobs:
           yarn config set cache-folder ${{ github.workspace }}/.yarn-cache
           make setup-js
       - name: 'test native(er) packages'
-        run: make test-js-internal tests="${{}matrix.shell}/src" cov_opts="--coverage=true"
+        run: make test-js-internal tests="${{matrix.shell}}/src" cov_opts="--coverage=true"
       - name: 'Upload coverage report'
         uses: 'codecov/codecov-action@v3'
         with:
diff --git a/app/src/organisms/ApplyHistoricOffsets/hooks/useHistoricRunDetails.ts b/app/src/organisms/ApplyHistoricOffsets/hooks/useHistoricRunDetails.ts
index cadfc5cf618..39f6d5e59b8 100644
--- a/app/src/organisms/ApplyHistoricOffsets/hooks/useHistoricRunDetails.ts
+++ b/app/src/organisms/ApplyHistoricOffsets/hooks/useHistoricRunDetails.ts
@@ -6,11 +6,13 @@ export function useHistoricRunDetails(
   hostOverride?: HostConfig | null
 ): RunData[] {
   const { data: allHistoricRuns } = useNotifyAllRunsQuery({}, {}, hostOverride)
-
   return allHistoricRuns == null
     ? []
-    : allHistoricRuns.data.toSorted(
-        (a, b) =>
-          new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime()
-      )
+    : // TODO(sf): figure out why .toSorted() doesn't work in vitest
+      allHistoricRuns.data
+        .map(t => t)
+        .sort(
+          (a, b) =>
+            new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime()
+        )
 }
diff --git a/app/src/pages/ODD/RobotDashboard/index.tsx b/app/src/pages/ODD/RobotDashboard/index.tsx
index 80ae745b055..aa255717388 100644
--- a/app/src/pages/ODD/RobotDashboard/index.tsx
+++ b/app/src/pages/ODD/RobotDashboard/index.tsx
@@ -41,8 +41,7 @@ export function RobotDashboard(): JSX.Element {
   )
 
   const recentRunsOfUniqueProtocols = (allRunsQueryData?.data ?? [])
-    .toReversed() // newest runs first
-    .reduce<RunData[]>((acc, run) => {
+    .reduceRight<RunData[]>((acc, run) => {
       if (
         acc.some(collectedRun => collectedRun.protocolId === run.protocolId)
       ) {
diff --git a/app/src/redux/config/__tests__/config.test.ts b/app/src/redux/config/__tests__/config.test.ts
index d99eb95c36e..bf5b4e98004 100644
--- a/app/src/redux/config/__tests__/config.test.ts
+++ b/app/src/redux/config/__tests__/config.test.ts
@@ -28,6 +28,7 @@ describe('config', () => {
       expect(Cfg.configInitialized(state.config as any)).toEqual({
         type: 'config:INITIALIZED',
         payload: { config: state.config },
+        meta: { shell: true },
       })
     })
 
@@ -35,6 +36,7 @@ describe('config', () => {
       expect(Cfg.configValueUpdated('foo.bar', false)).toEqual({
         type: 'config:VALUE_UPDATED',
         payload: { path: 'foo.bar', value: false },
+        meta: { shell: true },
       })
     })