-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/erc777 #1159 #1684
Feature/erc777 #1159 #1684
Conversation
This implementation conforms to the current EIP
OK, I drop trying to make the unit tests pass. For an unknown reason, I can't deploy an ERC1820 registry contract because it has already been deployed (nonce = 1), but I can't access the existing one and all the tests fail. |
Hello @catageek! Sorry for taking so long to review this, I was out of town for a couple days. One small comment before I review the code proper:
From my understanding of the EIP copyright, all rights are waved via CC0. This includes the contract interfaces, so we should be free to use them and re-license them under MIT (OpenZeppelin's license). IANAL though. |
@catageek if you don't mind, I'll start working directly on top of your commits in your branch, since there are multiple extremely minor things to polish. The overall PR looks absolutely great though, thanks a bunch! This is probably one of the best contributions to the repo I've seen: most issues come from the sheer size of it. I'll also look into the tests and see if I can figure out what's going on there. I'll try to keep the commits to the point so that this can be more easily reviewed. Once again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a first pass review through the ERC777
contract. The documentation needs a lot of work here, but we'll do that in a separate PR.
All that's missing now are the |
Co-Authored-By: nventuro <[email protected]>
For reference, I measured the gas cost of a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1159
This PR adds a ERC777 compatible token contract in the drafts folder.
A few points: