Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Check structs in storage layout validation #112

Open
spalladino opened this issue Sep 21, 2018 · 0 comments
Open

Check structs in storage layout validation #112

spalladino opened this issue Sep 21, 2018 · 0 comments
Labels
kind:enhancement Enhancement to an existing feature topic:storage-checks Storage compatibility validations

Comments

@spalladino
Copy link
Contributor

When comparing storage layouts, we are only comparing by variable name and type identifier, without checking if the type changed at all. For instance, these two contracts should be incompatible:

contract V1 {
  struct MyStruct { uint256 s1; }
  MyStruct a;
  uint256 b;
}

contract V2 {
  struct MyStruct { uint256 s1; uint256 s2; }
  MyStruct a;
  uint256 b;
}

We need to add recursive checks for layout of structs.

Follows from #92.

@spalladino spalladino added kind:enhancement Enhancement to an existing feature topic:storage-checks Storage compatibility validations labels Sep 21, 2018
@spalladino spalladino mentioned this issue Sep 21, 2018
4 tasks
@facuspagnuolo facuspagnuolo added this to the Backlog milestone Sep 24, 2018
@spalladino spalladino removed this from the Backlog milestone Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:enhancement Enhancement to an existing feature topic:storage-checks Storage compatibility validations
Projects
None yet
Development

No branches or pull requests

2 participants